[Mesa-dev] [PATCH 2/2] R600/SI: Merge offset0 and offset1 fields for single address DS instructions

[Michel Dänzer]

On Don, 2013-09-05 at 14:36 -0400, Tom Stellard wrote:
> From: Tom Stellard <thomas.stellard at amd.com>
> 
> Also remove unused data fields from the DS_Load_Helper class.

[...]

> diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td
> index 31a5ad2..94dcf2c 100644
> --- a/lib/Target/R600/SIInstructions.td
> +++ b/lib/Target/R600/SIInstructions.td
> @@ -1754,7 +1754,7 @@ def : Pat <
>  
>  class DSReadPat <DS inst, ValueType vt, PatFrag frag> : Pat <
>    (frag i32:$src0),
> -  (vt (inst 0, $src0, $src0, $src0, 0, 0))
> +  (vt (inst 0, $src0, 0))
>  >;
>  
>  def : DSReadPat <DS_READ_I8,  i32, sextloadi8_local>;
> @@ -1764,7 +1764,7 @@ def : DSReadPat <DS_READ_U16, i32, az_extloadi16_local>;
>  def : DSReadPat <DS_READ_B32, i32, local_load>;
>  def : Pat <
>      (local_load i32:$src0),
> -    (i32 (DS_READ_B32 0, $src0, $src0, $src0, 0, 0))
> +    (i32 (DS_READ_B32 0, $src0, 0))
>  >;
>  
>  class DSWritePat <DS inst, ValueType vt, PatFrag frag> : Pat <

Any particular reason for not giving DS_WRITE_B32 the corresponding
treatment?

LGTM other than that.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer