[Mesa-dev] [PATCH 1/3] i965: Add comments to the new brw_state_state structure's fields.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> These are largely based on the similar fields in brw->wm.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_context.h | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h
> index 57f086b..97c66ab 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.h
> +++ b/src/mesa/drivers/dri/i965/brw_context.h
> @@ -821,15 +821,22 @@ struct brw_query_object {
>   */
>  struct brw_stage_state
>  {
> +   /** Scratch buffer */
>     drm_intel_bo *scratch_bo;

This one doesn't tell me anything more than the variable's name.
"Optional scratch buffer used to store spilled register values" maybe?

Other than that, this series is:

Reviewed-by: Eric Anholt <eric at anholt.net>

I think patch 3 wants a patch to follow it that merges
brw_wm_binding_table and brw_vec4_upload_binding_table, at least.  And
that could be in a fancy new brw_surface_state.c file maybe, instead of
stuffed in one of the two stages?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130906/cda52ea0/attachment.pgp>