[Mesa-dev] [PATCH] mesa: Ensure gl_query_object is fully initialized.

[Brian Paul]

On 09/06/2013 01:39 PM, Vinson Lee wrote:
> 278372b47e4db8a022d57f60302eec74819e9341 added the uninitialized pointer
> field gl_query_object:Label. A free of this pointer resulted in a crash.
>
> This patch fixes piglit regressions with swrast introduced by
> 6d8dd59cf53d2f47b817d79204a52bb3a46e8c77.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69047
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   src/mesa/main/queryobj.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
> index 6b636f4..a180133 100644
> --- a/src/mesa/main/queryobj.c
> +++ b/src/mesa/main/queryobj.c
> @@ -43,7 +43,7 @@
>   static struct gl_query_object *
>   _mesa_new_query_object(struct gl_context *ctx, GLuint id)
>   {
> -   struct gl_query_object *q = MALLOC_STRUCT(gl_query_object);
> +   struct gl_query_object *q = CALLOC_STRUCT(gl_query_object);
>      (void) ctx;
>      if (q) {
>         q->Id = id;
>

Reviewed-by: Brian Paul <brianp at vmware.com>