[Mesa-dev] [PATCH 0/5] MESA_shader_integer_mix

[Ian Romanick]

On 09/06/2013 05:57 PM, Matt Turner wrote:
> This series implements a small extension that adds int, uint, and bool
> as allowable types to the mix() built-in function. We hope to make it
> an EXT extension soon.
> 
> I found myself wanting a per-component conditional-select operation
> when implementing the ldexp() and frexp() built-ins, and this
> extension came as a natural result.
> 
> The third patch switches the _mix_sel implementation from conditional
> assignment to conditional select. I've verified that there are no
> instruction count differences in shader-db.
> 
> Given Gallium support for ir_triop_cond_sel this extension can be
> enabled everywhere with GLSL 1.30 or GLSL ES 3.0. (Please add Gallium
> support, see patch 1)
> 
> The series is based on top of Ken's builtins-v3.2 branch.

Patches 2, 3, and 4 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

as-is.

Patch 1 is also Reviewed-by with the one change requested.

Patch 5 is Reviewed-by as-is, but I also made a small suggestion.

> Thanks,
> Matt