[Mesa-dev] [PATCH 2/2] R600/SI: Merge offset0 and offset1 fields for single address DS instructions v2

Michel Dänzer michel at daenzer.net
Mon Sep 9 07:21:36 PDT 2013


On Fre, 2013-09-06 at 11:06 -0400, Tom Stellard wrote:
> From: Tom Stellard <thomas.stellard at amd.com>
> 
> Also remove unused data fields from the DS_Load_Helper class.
> 
> v2:
>   - Merge fields for DS_WRITE

[...]

> -class DS_Store_Helper <bits<8> op, string asm, RegisterClass regClass> : DS <
> +class DS_Store_Helper <bits<8> op, string asm, RegisterClass regClass> : DS_1A <
>    op,
>    (outs),
> -  (ins i1imm:$gds, VReg_32:$addr, VReg_32:$data0, VReg_32:$data1,
> -       i8imm:$offset0, i8imm:$offset1),
> -  asm#" $gds, $addr, $data0, $data1, $offset0, $offset1, [M0]",
> +  (ins i1imm:$gds, VReg_32:$addr, VReg_32:$data0, i16imm:$offset),
> +  asm#" $gds, $addr, $data0, $offset [M0]",
>    []> {
>    let mayStore = 1;
>    let mayLoad = 0;
>    let vdst = 0;
>  }

The register class parameter can be removed from this class as well.
Either way,

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer



More information about the mesa-dev mailing list