[Mesa-dev] [PATCH 2/3] r600g: add support for separately allocated CMASKs

[Grigori Goronzy]

On 09.09.2013 16:09, Marek Olšák wrote:
>>          /* Check colorbuffers. */
>>          for (i = 0; i < rctx->framebuffer.state.nr_cbufs; i++) {
>> +               struct r600_texture *tex =
>> +                       (struct r600_texture*)rctx->framebuffer.state.cbufs[i]->texture;
>> +
>
> Please check if cbufs[i] != NULL.
>

This seems to be wrong in a lot of places. It is a general issue and I 
think this should really be tackled in a separate commit. I'll fix up 
this part (to not regress the particular function), but leave it at that.

Introducing NULL checks everywhere is not particularly neat anyway. I 
wonder if there is a better way...

Best regards
Grigori