[Mesa-dev] [PATCH] glsl: Add missing va_end in builtin_builder::add_function.

Kenneth Graunke kenneth at whitecape.org
Mon Sep 9 23:15:42 PDT 2013


On 09/09/2013 08:34 PM, Vinson Lee wrote:
> Fixes "Missing varargs init or cleanup" defect reported by Coverity.
> 
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/glsl/builtin_functions.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
> index 5d8f171..39127e6 100644
> --- a/src/glsl/builtin_functions.cpp
> +++ b/src/glsl/builtin_functions.cpp
> @@ -1850,6 +1850,7 @@ builtin_builder::add_function(const char *name, ...)
>  
>        f->add_signature(sig);
>     }
> +   va_end(ap);
>  
>     shader->symbols->add_function(f);
>  }
> 

Oooooops.   Thanks for catching this!

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list