[Mesa-dev] [PATCH 2/9] i965/gs: Add a state atom to set up geometry shader state.

Paul Berry stereotype441 at gmail.com
Tue Sep 10 20:14:43 PDT 2013


On 9 September 2013 16:31, Kenneth Graunke <kenneth at whitecape.org> wrote:

> On 09/09/2013 08:20 AM, Paul Berry wrote:
> > +const struct brw_tracked_state gen7_gs_state = {
> > +   .dirty = {
> > +      .mesa  = _NEW_PROGRAM_CONSTANTS,
>
> I'm pretty sure you need _NEW_TRANSFORM here.  The atom earlier in this
> patch will upload new push constant data if _NEW_TRANSFORM is set, so
> you'll want to emit 3DSTATE_CONSTANT_GS to point to the new constant
> data as well.
>
> Otherwise, this looks good.
>

Good point.  Fixed, thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130910/89aa4952/attachment.html>


More information about the mesa-dev mailing list