[Mesa-dev] [PATCH] gallium/dri-targets: hide all symbols except for __driDriverExtensions

[Jakob Bornecrantz]

On Thu, Aug 15, 2013 at 7:38 AM, Chia-I Wu <olvaffe at gmail.com> wrote:

> On Thu, Aug 15, 2013 at 1:26 PM, Chia-I Wu <olvaffe at gmail.com> wrote:
> > On Sat, Aug 10, 2013 at 2:56 AM, Marek Olšák <maraeo at gmail.com> wrote:
> >> Most importantly, this hides all LLVM symbols. They shouldn't clash
> >> with a different LLVM version used by apps (at least in theory).
> >>
> >> $ nm -g --defined-only radeonsi_dri.so
> >> 01148f30 D __driDriverExtensions
> > I am not familiar with issues regarding LLVM symbols so I am fine with
> > the change if this is what needs to be done (except maybe use
> > -export-symbols-regex __driDriverExtensions to avoid the version
> > script?)
> >
> > But I ran the nm command on ilo_dri.so, and almost all of the exported
> > symbols are from libdricommon or st/dri.  I think those two components
> > need VISIBILITY_CFLAGS in their AM_CFLAGS and __driDriverExtensions
> > needs to be marked as PUBLIC.  This way other gallium targets can
> > benefit.
> There is no other gallium target that uses st/dri :)
>
> Anyway, in addition to controlling exported symbols using symbol
> files, I still like to see VISIBILITY_CFLAGS be added to st/dri and
> the dri targets, which directly list source files from libdrmcommon in
> their SOURCES.  Besides, it seems __driConfigOptions and
> __dri2ConfigOptions are also marked PUBLIC.  Do they need to be
> exported?
>

I tested the v2 patch on vmwgfx worked but driconf complained after
adding the above two symbols to dri.versions and driconf worked so:

Tested-by: Jakob Bornecrantz <jakob at vmware.com>
Reviewed-by: Jakob Bornecrantz <jakob at vmware.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130912/4d5dbda6/attachment.html>