[Mesa-dev] gallium-bind-sampler-states branch

[Chia-I Wu]

Hi Brian,

On Fri, Sep 13, 2013 at 8:46 AM, Brian Paul <brianp at vmware.com> wrote:
>
> I just pushed a gallium-bind-sampler-states branch to my git repo at
> git://people.freedesktop.org/~brianp/mesa
>
> It replaces the four
> pipe_context::bind_fragment/vertex/geometry/compute_sampler_states()
> functions with a single bind_sampler_states() function:
>
>  void (*bind_sampler_states)(struct pipe_context *,
>                              unsigned shader, unsigned start_slot,
>                              unsigned num_samplers, void **samplers);
>
> At this point start_slot is always zero (at least for non-compute shaders).
> And as the updated gallium docs explain, at some point calls to
> bind_sampler_states() will be used to updated sub-ranges, but that never
> happens currently.
>
> I've updated all the drivers, state trackers, utils, etc.
>
> I've tested the svga, llvmpipe and softpipe drivers.  'make check' and a
> texture subset of piglit pass w/out regressions.  I'd appreciate it if other
> driver developers would test their favorite driver.
For ilo, the new code does not follow the doc and unbinds samplers not in range.

Is it fine if I implement the new bind_sampler_states as a helper
function on master branch, so that you hook it up to
pipe_context::bind_sampler_states in your branch and remove the old
ones?

>
> Next, I'd like to consolidate the
> set_vertex/geometry/fragment/compute_sampler_views() functions with a single
> function.  But I have no idea when I'll get around to that.
>
> -Brian
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev



-- 
olv at LunarG.com