[Mesa-dev] regression on nvc0 since floating point compare instructions

[Dave Airlie]

On Fri, Sep 13, 2013 at 12:24 AM, Christoph Bumiller
<e0425955 at student.tuwien.ac.at> wrote:
> On 12.09.2013 16:14, Roland Scheidegger wrote:
>> Am 12.09.2013 03:40, schrieb Dave Airlie:
>>>> Maybe the type isn't set correctly? Looks to me like these instructions
>>>> end up in mkCmp, which will set both src and dst type but ignore src
>>>> type and set both according to the same type (which was the dst type).
>>>>
>>>> Roland
>>> Okay I've attached my next attempt at fixing it, fixes the two testcases I had.
>>
>> No idea what setting type there really does but I guess that looks right
>> :-). Though I'm wondering if U32 vs. S32 would make a difference for dst
>> type since some of the (unsigned) comparisons still would use U32.
>
> It doesn't make a difference, making it signed is unnecessary.
> If it helped before that was just because it made negative floats be
> interpreted as negative ints (instead of large ints) which has a
> slightly better chance of "succeeding".

Cool I've dropped that bit then, and it still works fine! so I'll push
the remains.

Dave.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-nouveau-fix-regression-since-float-comparison-instru.patch
Type: application/octet-stream
Size: 7439 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130914/8d16e6e6/attachment.obj>