[Mesa-dev] [PATCH 08/24] glsl: Add new atomic_uint built-in GLSL type.

[Francisco Jerez]

Paul Berry <stereotype441 at gmail.com> writes:

> On 17 September 2013 14:14, Francisco Jerez <currojerez at riseup.net> wrote:
>
>> Paul Berry <stereotype441 at gmail.com> writes:
>>
>> > On 17 September 2013 12:18, Paul Berry <stereotype441 at gmail.com> wrote:
>> >[...]
>> > I also notice that most of your uses of atomic_size() in this patch
>> series
>> > are merely to see whether the type contains any atomics.  You might
>> > consider adding a contains_atomic() function (like we've already done
>> with
>> > contains_sampler() and contains_integer()) just for code clarity.
>>
>> Not really, we also need the actual size in a couple of places, like
>> ast_to_hir.cpp:2256, link_atomics.cpp:80 and link_atomics.cpp:123.
>>
>> Thanks.
>>
>
> I wasn't suggesting replacing it.  I was suggesting adding a
> contains_atomic() function so that in those places where we don't need the
> actual size (which are the majority of cases) the code would be clearer.
>
> contains_atomic() might just be an inline function that calls atomic_size().

Oh, right...  I will do that.

Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130918/ffd270e9/attachment.pgp>