[Mesa-dev] [PATCH 07/11] i965: Switch ip_record to the non-zeroing allocator.

Francisco Jerez currojerez at riseup.net
Fri Sep 20 21:51:45 PDT 2013


All member variables of ip_record are already being initialized from
its constructor, it's not necessary to use rzalloc to allocate its
memory, and doing so makes it more likely that we will start relying
on the allocator to zero out all memory if the class is ever extended
with new member variables.

That's bad because it ties objects to some specific allocation scheme,
and gives unpredictable results when an object is created with a
different allocator -- Stack allocation, array allocation, or
aggregation inside a different object are some of the useful
possibilities that come to my mind.
---
 src/mesa/drivers/dri/i965/brw_fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h
index b2aa041..8d35112 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.h
+++ b/src/mesa/drivers/dri/i965/brw_fs.h
@@ -112,7 +112,7 @@ static const fs_reg reg_null_d(ARF, BRW_ARF_NULL, BRW_REGISTER_TYPE_D);
 
 class ip_record : public exec_node {
 public:
-   DECLARE_RZALLOC_CXX_OPERATORS(ip_record)
+   DECLARE_RALLOC_CXX_OPERATORS(ip_record)
 
    ip_record(int ip)
    {
-- 
1.8.3.4



More information about the mesa-dev mailing list