[Mesa-dev] [PATCH 5/7] mesa: Drop an extra copy-and-pasted copy in the program clone function.

Brian Paul brian.e.paul at gmail.com
Sat Sep 21 08:00:13 PDT 2013


On Fri, Sep 20, 2013 at 7:52 PM, Eric Anholt <eric at anholt.net> wrote:
> ---
>  src/mesa/program/program.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c
> index 5dd68d9..aa3c5b4 100644
> --- a/src/mesa/program/program.c
> +++ b/src/mesa/program/program.c
> @@ -485,7 +485,6 @@ _mesa_clone_program(struct gl_context *ctx, const struct gl_program *prog)
>     if (prog->Parameters)
>        clone->Parameters = _mesa_clone_parameter_list(prog->Parameters);
>     memcpy(clone->LocalParams, prog->LocalParams, sizeof(clone->LocalParams));
> -   memcpy(clone->LocalParams, prog->LocalParams, sizeof(clone->LocalParams));
>     clone->IndirectRegisterFiles = prog->IndirectRegisterFiles;
>     clone->NumInstructions = prog->NumInstructions;
>     clone->NumTemporaries = prog->NumTemporaries;


Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list