[Mesa-dev] [PATCH 1/5] ralloc: Introduce new macros for defining C++ new/delete operators.

Kenneth Graunke kenneth at whitecape.org
Sat Sep 21 09:30:26 PDT 2013


On 09/19/2013 03:35 PM, Ian Romanick wrote:
> I like this approach a lot... certainly a lot more than various
> inheritance-based approaches that we had discussed before.
> 
> Patches 1, 2, 3, and 5 are
> 
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> 
> Patch 4 probably is too (with the comment addition that I suggested),
> but I'd like to hear your thoughts about the performance implication
> that I mentioned first.

Since Ian, Eric, and Chad all responded favorably to the first three
patches, and Francisco has started writing patches based against it,
I've gone ahead and landed those.

I've held off on the last two (hooking up destructors globally) due to
Ian's concerns.  It sounds like more discussion is necessary, which we
can probably resume once things are a bit less chaotic :)

--Ken


More information about the mesa-dev mailing list