[Mesa-dev] [PATCH 1/2] i965/fs: Remove explicit resolve_ud_negate from emit_bool_to_cond_code.

Kenneth Graunke kenneth at whitecape.org
Mon Sep 23 14:12:25 PDT 2013


resolve_ud_negate works around issues with the CMP instruction; it isn't
necessary for other instructions.

Since Eric originally wrote this code, we've added the CMP() instruction
emitter, which now internally does resolve_ud_negate() on both operands.

So we can drop the explicit calls to resolve_ud_negate(): they'll either
get done by the CMP() emitter, or they aren't necessary anyway.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index 3d25fe3..946525b 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
@@ -1734,8 +1734,6 @@ fs_visitor::emit_bool_to_cond_code(ir_rvalue *ir)
 
 	 expr->operands[i]->accept(this);
 	 op[i] = this->result;
-
-	 resolve_ud_negate(&op[i]);
       }
 
       switch (expr->operation) {
-- 
1.8.3.4



More information about the mesa-dev mailing list