[Mesa-dev] [PATCH 1/2] st/clover: Clear the complete queue

[Francisco Jerez]

Niels Ole Salscheider <niels_ole at salscheider-online.de> writes:

> Events that are already signalled can be removed from the queue, too.
>
> Signed-off-by: Niels Ole Salscheider <niels_ole at salscheider-online.de>

I don't think this is right, with this patch we remove *all* events from
the command queue, signalled or not, every time the command queue is
flushed.

> ---
>  src/gallium/state_trackers/clover/core/queue.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/clover/core/queue.cpp b/src/gallium/state_trackers/clover/core/queue.cpp
> index 0b1c494..500a636 100644
> --- a/src/gallium/state_trackers/clover/core/queue.cpp
> +++ b/src/gallium/state_trackers/clover/core/queue.cpp
> @@ -56,7 +56,7 @@ _cl_command_queue::flush() {
>        pipe->flush(pipe, &fence, 0);
>        std::for_each(first, last, [&](event_ptr &ev) { ev->fence(fence); });
>        screen->fence_reference(screen, &fence, NULL);
> -      queued_events.erase(first, last);
> +      queued_events.clear();
>     }
>  }
>  
> -- 
> 1.8.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130926/435c5d1c/attachment.pgp>