[Mesa-dev] [PATCH 1/7] dri: Remove dead comment.

Kenneth Graunke kenneth at whitecape.org
Thu Sep 26 21:31:12 PDT 2013


On 09/26/2013 08:35 PM, Eric Anholt wrote:
> The code it was referencing was removed in 2010.
> ---
>  src/mesa/drivers/dri/common/dri_util.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c
> index fa520ea..b95970d 100644
> --- a/src/mesa/drivers/dri/common/dri_util.c
> +++ b/src/mesa/drivers/dri/common/dri_util.c
> @@ -435,10 +435,6 @@ static int driUnbindContext(__DRIcontext *pcp)
>  	dri_put_drawable(prp);
>      }
>  
> -    /* XXX this is disabled so that if we call SwapBuffers on an unbound
> -     * window we can determine the last context bound to the window and
> -     * use that context's lock. (BrianP, 2-Dec-2000)
> -     */
>      pcp->driDrawablePriv = NULL;
>      pcp->driReadablePriv = NULL;
>  
> 

Patches 1-2, 4-7 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(assuming you fix the one thing in patch 4)

I'm not planning on reviewing patch 3.  Looks reasonable, but I don't
know that part of the code terribly well.


More information about the mesa-dev mailing list