[Mesa-dev] [PATCH] i965: Update the comment about viewport hacks.
Kenneth Graunke
kenneth at whitecape.org
Fri Sep 27 10:14:23 PDT 2013
It wasn't clear that this was necessary for EGL, or why.
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/mesa/drivers/dri/i965/intel_context.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_context.c b/src/mesa/drivers/dri/i965/intel_context.c
index 5a73e28..850b18c 100644
--- a/src/mesa/drivers/dri/i965/intel_context.c
+++ b/src/mesa/drivers/dri/i965/intel_context.c
@@ -373,7 +373,13 @@ intelInitContext(struct brw_context *brw,
int bo_reuse_mode;
struct gl_config visual;
- /* Can't rely on invalidate events, fall back to glViewport hack */
+ /* GLX uses DRI2 invalidate events to handle window resizing.
+ * Unfortunately, EGL does not - libEGL is written in XCB (not Xlib),
+ * which doesn't provide a mechanism for snooping the event queues.
+ *
+ * So EGL still relies on viewport hacks to handle window resizing.
+ * This should go away with DRI3000.
+ */
if (!driContextPriv->driScreenPriv->dri2.useInvalidate) {
brw->saved_viewport = functions->Viewport;
functions->Viewport = intel_viewport;
--
1.8.3.4
More information about the mesa-dev
mailing list