[Mesa-dev] [PATCH 1/5] glsl_compiler: Use no_argument instead of 0 in getopt_long options

Ian Romanick idr at freedesktop.org
Fri Sep 27 11:58:02 PDT 2013


From: Ian Romanick <ian.d.romanick at intel.com>

The choices aren't just 0 and 1, so using the enum names is much more
clear.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
This goes on top of the series that I just sent.  I sent them as
separate series because they're logically separate.  I don't think there
will be many issues with the other, but there will likely be some
disucssion about this one.

Since I made this available as a branch, one ISV has already started
experimenting with it.

 src/glsl/main.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp
index 57bec44..bc15835 100644
--- a/src/glsl/main.cpp
+++ b/src/glsl/main.cpp
@@ -110,11 +110,11 @@ int dump_lir = 0;
 int do_link = 0;
 
 const struct option compiler_opts[] = {
-   { "glsl-es",  0, &glsl_es,  1 },
-   { "dump-ast", 0, &dump_ast, 1 },
-   { "dump-hir", 0, &dump_hir, 1 },
-   { "dump-lir", 0, &dump_lir, 1 },
-   { "link",     0, &do_link,  1 },
+   { "glsl-es",  no_argument, &glsl_es,  1 },
+   { "dump-ast", no_argument, &dump_ast, 1 },
+   { "dump-hir", no_argument, &dump_hir, 1 },
+   { "dump-lir", no_argument, &dump_lir, 1 },
+   { "link",     no_argument, &do_link,  1 },
    { NULL, 0, NULL, 0 }
 };
 
-- 
1.8.1.4



More information about the mesa-dev mailing list