[Mesa-dev] [PATCH 4/9] i965: Stop allocating miptrees with first_level != 0.

Chad Versace chad.versace at linux.intel.com
Fri Sep 27 15:50:15 PDT 2013


On 09/18/2013 12:59 PM, Eric Anholt wrote:
> If the caller shows up with GL_BASE_LEVEL != 0, it doesn't mean that the
> texture will over the course of its lifetime have that nonzero baselevel,
> it means that the caller is filling the texture from the bottom up for
> some reason (one could imagine demand-loading detailed texture layers at
> runtime, for example).  If we allocate from just the current baselevel, it
> means when they come along with the next level up, we'll have to allocate
> a new miptree and copy all of our bits out of the first miptree.
> ---
>   src/mesa/drivers/dri/i965/intel_tex_image.c | 23 ++++++-----------------
>   1 file changed, 6 insertions(+), 17 deletions(-)

I like patches 3 and 4. They make the teximage and miptree code cleaner and
easier to reason about. They are
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>



More information about the mesa-dev mailing list