[Mesa-dev] [PATCH RESEND 0/3] gallium: replacing X11_CFLAGS with X11_INCLUDES

[Emil Velikov]

On 28/09/13 01:39, Gaetan Nadon wrote:
> On 13-09-27 07:59 PM, Brian Paul wrote:
>> On 09/27/2013 03:42 PM, Gaetan Nadon wrote:
>>> The X11_CFLAGS variable is undefined (not defined in config.status).
>>> It appears the intent was to use X11_INCLUDES defined in configure.ac.
>>>
>>> Gaetan Nadon (3):
>>>    gallium/targets/libgl-xlib: X11/Xlib.h: No such file or directory
>>>    gallium/state_trackers/egl: use X11_INCLUDES rather than X11_CFLAGS
>>>    gallium/state_trackers/glx: X11/Xlib.h: No such file or directory
>>>
>>>   src/gallium/state_trackers/egl/Makefile.am |    2 +-
>>>   src/gallium/state_trackers/glx/Makefile.am |    2 +-
>>>   src/gallium/targets/libgl-xlib/Makefile.am |    2 +-
>>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>
>> I'm no expert on the build system but this seems OK to me.
>>
>> Acked-by: Brian Paul <brianp at vmware.com>
>>
>> Tag for the 9.2 branch?
> 
> I couldn't say. It's not urgent. I don't have commit access.
> 
> FYI, Kenneth Graunke pushed similar patches recently. I just happenned
> to find a few more cases.
> http://lists.freedesktop.org/archives/mesa-dev/2013-September/044912.html
> 
> Thanks!
> 

While you're in the X11_* neighbourhood I've noticed a case of X11_LIBS,
which seems a bit odd(undefined). Would you be able to decypher it ?

Thanks
Emil

>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>