[Mesa-dev] Janitorial work: no more intel_context.[ch]; tidying

[Emil Velikov]

On 28/09/13 00:45, Kenneth Graunke wrote:
> This series combines brw_context.[ch] and intel_context.[ch],
> and cleans up our context creation code quite a bit.  A bunch of
> functionality was awkwardly split between the two sets of files;
> now it's all in one place.
> 
> While this series is large, it should be fairly easy reading.
> Patch 28 does have one functional change on 32-bit systems - it removes
> a handcoded assembly version of memcpy.  This has not been tested.
> 
Hi Kenneth

Hope you can bare with me and a couple of silly questions :)

* With the recent split of the intel driver codebase, the new i965
headers has been getting a bunch of #pragma once over the standard
#ifndef _HEADER_H_... Are those intentional ?

* In patch 29 the drm* headers are included quoted, over angle brackets.
I realise that's a very pedantic point, just curious is it just a
copy'n'paste thing or was it planned.

* The inline function is_power_of_two() in patch 29 is used by both
intel drivers. Possibly move it to macros.h ? Gallium has it's
equivalent in auxiliary/util/u_math.h - util_is_power_of_two()

Thanks
Emil
> Available as 'tidying6' in my tree.  Based on Eric's megadriver-prep series.
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>