[Mesa-dev] [PATCH v2] nv30: Clear dirty bit for processed samplers.

Vinson Lee vlee at freedesktop.org
Fri Sep 27 21:20:07 PDT 2013


Otherwise, the while(dirty) loop will never exit.

Fixes "Infinite loop" defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
---
 src/gallium/drivers/nouveau/nv30/nv40_verttex.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gallium/drivers/nouveau/nv30/nv40_verttex.c b/src/gallium/drivers/nouveau/nv30/nv40_verttex.c
index 9a7163c..d244e7f 100644
--- a/src/gallium/drivers/nouveau/nv30/nv40_verttex.c
+++ b/src/gallium/drivers/nouveau/nv30/nv40_verttex.c
@@ -42,6 +42,8 @@ nv40_verttex_validate(struct nv30_context *nv30)
          BEGIN_NV04(push, NV40_3D(VTXTEX_ENABLE(unit)), 1);
          PUSH_DATA (push, 0);
       }
+
+      dirty &= ~(1 << unit);
    }
 
    nv30->vertprog.dirty_samplers = 0;
-- 
1.8.3.1



More information about the mesa-dev mailing list