[Mesa-dev] [PATCH] draw: Add a null check for draw.

[Brian Paul]

On 09/27/2013 10:51 PM, Vinson Lee wrote:
> There is an earlier null check for draw so draw could be null here as
> well.
>
> Fixes "Dereference after null check" defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   src/gallium/auxiliary/draw/draw_pipe_unfilled.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/draw/draw_pipe_unfilled.c b/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
> index 7a88ce0..8cba07c 100644
> --- a/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
> +++ b/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
> @@ -237,7 +237,7 @@ draw_unfilled_prepare_outputs( struct draw_context *draw,
>      boolean is_unfilled = (rast &&
>                             (rast->fill_front != PIPE_POLYGON_MODE_FILL ||
>                              rast->fill_back != PIPE_POLYGON_MODE_FILL));
> -   const struct draw_fragment_shader *fs = draw->fs.fragment_shader;
> +   const struct draw_fragment_shader *fs = draw ? draw->fs.fragment_shader : 0;
>
>      if (is_unfilled && fs && fs->info.uses_frontface)  {
>         unfilled->face_slot = draw_alloc_extra_vertex_attrib(
>

Reviewed-by: Brian Paul <brianp at vmware.com>