[Mesa-dev] [PATCH 14/29] i965: Remove the brw_context::emit_state_always flag.

[Ian Romanick]

On 09/27/2013 04:45 PM, Kenneth Graunke wrote:
> This was always set to false, and is only used for debugging.
> To enable it, simply change the if (0) block and recompile.

So, the difference is that you could change emit_state_always in GDB,
but I'm not sure that matters.

> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_context.c      | 2 --
>  src/mesa/drivers/dri/i965/brw_context.h      | 2 --
>  src/mesa/drivers/dri/i965/brw_state_upload.c | 3 ++-
>  3 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
> index 125dbec..cca7145 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.c
> +++ b/src/mesa/drivers/dri/i965/brw_context.c
> @@ -471,8 +471,6 @@ brwCreateContext(int api,
>      */
>     STATIC_ASSERT(BRW_NUM_STATE_BITS <= 8 * sizeof(brw->state.dirty.brw));
>  
> -   brw->emit_state_always = 0;
> -
>     brw->batch.need_workaround_flush = true;
>  
>     ctx->VertexProgram._MaintainTnlProgram = true;
> diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h
> index 656fb3c..7e15186 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.h
> +++ b/src/mesa/drivers/dri/i965/brw_context.h
> @@ -1021,8 +1021,6 @@ struct brw_context
>  
>     uint32_t max_gtt_map_object_size;
>  
> -   bool emit_state_always;
> -
>     int gen;
>     int gt;
>  
> diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c
> index d7fe319..60c8b5e 100644
> --- a/src/mesa/drivers/dri/i965/brw_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_state_upload.c
> @@ -471,7 +471,8 @@ void brw_upload_state(struct brw_context *brw)
>     state->brw |= ctx->NewDriverState;
>     ctx->NewDriverState = 0;
>  
> -   if (brw->emit_state_always) {
> +   if (0) {
> +      /* Always re-emit all state. */
>        state->mesa |= ~0;
>        state->brw |= ~0;
>        state->cache |= ~0;
>