[Mesa-dev] [PATCH 4/4] xa: reuse surfaces

[Rob Clark]

On Tue, Apr 1, 2014 at 12:39 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 01/04/14 16:04, Rob Clark wrote:
>> From: Rob Clark <robclark at freedesktop.org>
>>
>> Otherwise it will trick the gallium driver into thinking that the render
>> target has actually changed (due to different pipe_surface pointing to
>> same underlying pipe_resource).  This is really badness for tiling GPUs
>> like adreno.
>>
> Hi Rob,
>
>> Signed-off-by: Rob Clark <robclark at freedesktop.org>
>> ---
>>  src/gallium/state_trackers/xa/xa_context.c | 35 +++++++++++++++++++++++-------
>>  src/gallium/state_trackers/xa/xa_priv.h    |  3 ++-
>>  src/gallium/state_trackers/xa/xa_tracker.c |  1 +
>>  3 files changed, 30 insertions(+), 9 deletions(-)
>>
> [snip]
>> diff --git a/src/gallium/state_trackers/xa/xa_priv.h b/src/gallium/state_trackers/xa/xa_priv.h
>> index 7a43386..5ade6c1 100644
>> --- a/src/gallium/state_trackers/xa/xa_priv.h
>> +++ b/src/gallium/state_trackers/xa/xa_priv.h
>> @@ -46,7 +46,7 @@
>>  #define XA_EXPORT
>>  #endif
>>
>> -#define XA_VB_SIZE (100 * 4 * 3 * 4)
>> +#define XA_VB_SIZE (170 * 4 * 3 * 4)
> A wild short in the dark here - I'm guessing that this change was meant to be
> part of another patch ?

Oh, yeah.. that was an attempt to bump the size up to closest page
boundary to see if it helped circles.  Turned out not to be the
issue.. probably that hunk should be dropped.

BR,
-R

>
> Cheers
> -Emil
>