[Mesa-dev] [PATCH 1/4] glapi: Remove support for "short string" mode

Brian Paul brianp at vmware.com
Tue Apr 1 13:44:02 PDT 2014


On 04/01/2014 02:15 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> C89 has a fairly short minimum-maximum string length.  To support
> compilers limited by the C89 limits, this script had a mode where it
> would generate a character array instead of a giant string.  These were
> functionally the same, but the code generated for the character array is
> HUGE and difficult to read.
>
> As far as I can tell, nothing in Mesa uses '-m short' any more.  The
> generated files used to be tracked in revision control, but I think we
> stopped using '-m short' when we stopped tracking the generated files.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: Vinson Lee <vlee at freedesktop.org>
> ---
>   src/mapi/glapi/gen/gl_procs.py | 43 +++++++-----------------------------------
>   1 file changed, 7 insertions(+), 36 deletions(-)
>

Build seems OK on Linux and Windows/MSVC with these patches.

Tested-by: Brian Paul <brianp at vmware.com>

Thanks, Ian.

-Brian



More information about the mesa-dev mailing list