[Mesa-dev] [PATCH] Revert "radeon: just don't map VRAM buffers at all"

[Christian König]

Am 01.04.2014 15:47, schrieb Leo Liu:
> From: Leo Liu <leo.liu at amd.com>
>
> This reverts commit 96e8b916a7a39a9ba58e92d1ad77b5501de63ac7.

The patch itself is ok, but we should probably add an explanation why we 
want to revert this.

Christian.

>
> Signed-off-by: Leo Liu <leo.liu at amd.com>
> ---
>   src/gallium/drivers/radeon/r600_texture.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c
> index 45a9508..3dfddca 100644
> --- a/src/gallium/drivers/radeon/r600_texture.c
> +++ b/src/gallium/drivers/radeon/r600_texture.c
> @@ -928,8 +928,8 @@ static void *r600_texture_transfer_map(struct pipe_context *ctx,
>   	if (rtex->surface.level[level].mode >= RADEON_SURF_MODE_1D)
>   		use_staging_texture = TRUE;
>   
> -	/* Untiled buffers in VRAM, which is slow for CPU reads and writes */
> -	if (!(usage & PIPE_TRANSFER_MAP_DIRECTLY) &&
> +	/* Untiled buffers in VRAM, which is slow for CPU reads */
> +	if ((usage & PIPE_TRANSFER_READ) && !(usage & PIPE_TRANSFER_MAP_DIRECTLY) &&
>   	    (rtex->resource.domains == RADEON_DOMAIN_VRAM)) {
>   		use_staging_texture = TRUE;
>   	}