[Mesa-dev] [PATCH V3 02/30] mesa: fix packing of float texels to GL_SHORT/GL_BYTE

Brian Paul brianp at vmware.com
Wed Apr 2 07:31:17 PDT 2014


On 04/02/2014 02:04 AM, Chris Forbes wrote:
> Previously, we would unpack the texels to floats using *_TO_FLOAT_TEX,
> and then pack them into the desired format using FLOAT_TO_*. Unfortunately,
> this isn't quite the inverse operation, and so some texel values would
> end up off-by-one.
>
> This fixes the GL_RGB8_SNORM and GL_RGB16_SNORM subcases in piglit's
> arb_texture_view-format-consistency-get test on i965. The similar 1-, 2-
> and 4-component cases already worked because they took the memcpy path
> rather than repacking.
>
> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> ---
>   src/mesa/main/pack.c | 116 +++++++++++++++++++++++++--------------------------
>   1 file changed, 58 insertions(+), 58 deletions(-)
>

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list