[Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

[Emil Velikov]

On 22/03/14 00:10, Emil Velikov wrote:
> On 19/03/14 01:06, Jonathan Gray wrote:
>> On Tue, Mar 18, 2014 at 07:56:21PM +0000, Emil Velikov wrote:
>>> On 18/03/14 14:59, Jonathan Gray wrote:
>>>> Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
>>>> ---
>>> Hi Jonathan
>>>
>>> While the summary covers what the patch does, the *ahem* commit message
>>> fails to explain why it's needed. AFAICS this will cause some very nasty
>>> breakage in some cases, which we want to avoid without a valid reason.
>>>
>>> -Emil
>>
>> The summary is the commit message though?
>>
>> Anyway without this I can't load dri drivers at all on OpenBSD
>> with mesa 10.x.  FreeBSD/NetBSD/Solaris/etc would also be broken
>> which strikes me as rather serious breakage...
>>
> Kind of expecting to see a fraction of the above in the commit message,
> maybe I was expecting too much.
> 
> Wrt "will cause some very nasty breakage" I take that back, as I've
> missed the commit that enforces libudev on linux, which handles those
> lovely scenarios.
> 
> FWIW For patches 1, 2 and 4.
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
> 
> Btw, if you're looking for egl, wayland, opencl etc. similar fixes to
> patch 3 may be needed.
> 
> Will slap Cc: mesa-stable on all three commits + the fix for fdo#76377,
> before pushing to master, although I would prefer to wait for a few days
> in case other people are interested in reviewing/testing.
> 
Planning to commit patches 1, 2 and 4 over the weekend. So if anyone has
strong feelings about them please speak up.

Cheers
-Emil

> Cheers
> -Emil
> 
>> udev is only available on Linux so every other platform
>> that uses dri is currently broken.
>>
>