[Mesa-dev] [PATCH] st/xa: Fix advertized version number and try to avoid future discrepancies

[Rob Clark]

On Thu, Apr 3, 2014 at 11:00 AM, Thomas Hellstrom <thellstrom at vmware.com> wrote:
> On 04/03/2014 04:49 PM, Rob Clark wrote:
>> On Thu, Apr 3, 2014 at 2:05 AM, Thomas Hellstrom <thellstrom at vmware.com> wrote:
>>> The xa version number had to be set in two places. In configure.ac and in
>>> xa_tracker.h. Furthermore, xa_tracker.h is an installed header so we can't
>>> use mesa internal defines. So therefore, at configure time, modify the
>>> xa_tracker.h header to use the version given by configure.ac
>>>
>>> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
>> btw, I was kicking around adding an API to query the actual version at
>> runtime (in case, for example, I wanted to only attempt to use
>> composite from DDX with newer XA versions)..
>>
>> Probably build-time version checks using the .pc file would be enough,
>> but I think a run-time version check could turn out to be useful
>>
>> BR,
>> -R
>>
>
> Hi,
> There's an xa_tracker_version() function that probably can be used for that?

oh, heh, I guess I should have noticed that

> BTW, was that a Reviewed-By:?

yeah,

Reviewed-by: Rob Clark <robdclark at gmail.com>


> Thanks,
> Thomas