[Mesa-dev] [PATCH] st/xa: Fix advertized version number and try to avoid future discrepancies

[Thomas Hellstrom]

On 04/04/2014 12:13 PM, Emil Velikov wrote:
> On 03/04/14 07:05, Thomas Hellstrom wrote:
>> The xa version number had to be set in two places. In configure.ac and in
>> xa_tracker.h. Furthermore, xa_tracker.h is an installed header so we can't
>> use mesa internal defines. So therefore, at configure time, modify the
>> xa_tracker.h header to use the version given by configure.ac
>>
> Can we please keep source files out of autoconf/automake ? It's never a good
> idea IMHO. While this works with automake, I'm guessing that it will fail with
> scons and the android.
>
> All that is needed is the three defines to be set by the build scripts -
> similar to the way vdpau does it.
>
> In the long term we can move all the library versions into a centralised place
> (perhaps inside the VERSION file) to avoid duplication/miss-match across our
> lovely build systems.
>
> And... seems like I was too late and you've pushed the patch already.
>
> -Emil
>
>

Hi.
Sorry about the breakage here. I'm out of office for the weekend, and
can't fix until monday so please revert if you need to.

Thanks,
Thomas