[Mesa-dev] [PATCH] egl/dri2: don't require libudev to build drm/wayland platforms

[Emil Velikov]

On 05/04/14 15:10, Jonathan Gray wrote:
> On Sat, Apr 05, 2014 at 02:12:31PM +0100, Emil Velikov wrote:
>> Hi Jonathan,
>>
>> Just pushed as many of your patches as I can see to master. Let me know if I
>> missed any.
>>
>> Some of the patches are stable material, so I've tagged them for the 10.1
>> stable branch.
>>
>> Thanks again.
>> -Emil
> 
> Great, thank you.
> 
> There are still a few things, not all of which I've sent out patches for.
> 
> http://marc.info/?l=mesa3d-dev&m=137534209528776&w=2
> removed a misused __gnu_linux__ ifdef, there was some
> discussion but no clear alternative out of it.
> 
Might be worth preparing a summary of the discussion (with links) and a few
possible solutions. Most people quite are busy so I'm guessing that they might
not have time to read through the whole thread.

> http://marc.info/?l=mesa3d-dev&m=139446389719785&w=2
> removed a grep escape sequence in ax_prog_flex.m4 that isn't as portable
> as grep -w.  This was later accepted upstream in
> http://git.savannah.gnu.org/cgit/autoconf-archive.git/commit/?id=98e799a84f7aa040ff755277c5788f6ffce541d6
> though they didn't reply to a mail after that on how to handle
> a string like 'gflex 2.5.35'.
> 
The patch looks good afaics, although it may be worth resending/pinging the list.

> In order to build I have to revert
> 'fix vdpau interop when using -Bsymbolic-functions in ldflags' 
> 8c136b53b79e90b9e8f30f891b8bef112fee375d
> as there is no --dynamic-list in ld here.
> 
AFAICS the most appropriate solution would be to add a linker/libtool check
similar to what I did with GC_SECTIONS. Please link the bugzilla report with
the patch.

> In r600/sb I have to move two '#include "r600_pipe.h"' lines outside
> of extern "C" to build, no patch sent out for that yet.
> 
> and I have an unsubmitted patch for configure.ac along the lines of
> -        CFLAGS="$CFLAGS -Wall -std=c99"
> +        CFLAGS="$CFLAGS -Wall -std=c99 -fms-extensions"
> for https://bugs.freedesktop.org/show_bug.cgi?id=76789
> otherwise radeonsi doesn't build.
> 
I would recommend Cc-ing a couple of the radeon people (git log) once you have
patches that work for you.

-Emil