[Mesa-dev] [PATCH mesa/mesa] Hardcode the DRI driver extension as .so to match it's current uses.

[Jon TURNEY]

On 06/04/2014 17:45, Emil Velikov wrote:
> Sorry about this breakage. I assumed that the library extensions are handled
> consistently across mesa. Seems like I was wrong.
> 
> Guessing that you meant to send this to the mesa-dev ?

Yes, sorry about that.

> On 06/04/14 15:59, Jon TURNEY wrote:
>> A similar fix is probably also needed for gallium DRI drivers.
>>
> Currently the only gallium related part is the "compatibility symlinks"
> script, that is enabled only for linux. Thanks for the heads up :)

That's the only place in gallium that LIB_EXT is used, but a '-shrext .so' is
needed somewhere (in GALLIUM_DRI_LINKER_FLAGS?) so that the gallium DRI
drivers are built with names matching those hardcoded into the loader.

>> (Consider that if we were starting from scratch, perhaps we would use a custom
>> extension like .dri instead)
>>
> IMHO if we're starting from scratch we should use the platform specific
> extensions consistently but neither suggestion matter in this case :'(

Can you explain your reasoning? This seems to me to be a foolish consistency.

For libraries which are only ever used with dlopen() and are not intended to
be linked with (i.e. have some sort of plug-in style interface), there is no
advantage to using the platform's default shared library extension, and it
introduces extra platform dependent code to determine the library name when
the library is used.

> With that said the patch is
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks.