[Mesa-dev] [PATCH 1/2] Revert "st/xa: Fix advertized version number and try to avoid future discrepancies"

Thomas Hellstrom thellstrom at vmware.com
Mon Apr 7 05:48:33 PDT 2014


On 04/07/2014 02:44 PM, Emil Velikov wrote:
> Parsing source files through build systems is never a good idea.
> Especially when the issue can be resolved by adding a couple of
> definitions to CPPFLAGS via the build system.

I've nothing against reverting the commit, but the log message is incorrect,
xa_tracker.h is an installed header and thus must include the correct
defines.
(see my commit message).

If we don't parse it using autoconf, we need to use sed or some other
tool to
fix the header.


Otherwise Acked-by: Thomas Hellstrom <thellstrom at vmware.com>

/Thomas


>
> This reverts commit 61bedc3d6b08943f015f9d590c07a6af36c2a92c.
>
> Cc: Thomas Hellstrom <thellstrom at vmware.com>
> ---
>


More information about the mesa-dev mailing list