[Mesa-dev] [PATCH 1/9] i965: Fix "SIMD16 unsupported" messages via KHR_debug.

[Ian Romanick]

I made a couple random comments on several patches.  I also like Ilia's
suggestion on patch 3.

Patches 1 through 8 (with Ilia's suggestion on 3) are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I think patch 9 still needs some work for signed numerator handling in
division.

On 04/06/2014 11:49 PM, Kenneth Graunke wrote:
> Performance warnings are logged via KHR_debug in addition to when the
> INTEL_DEBUG=perf environment variable is set.  Without this, messages in
> debug contexts would have "(null)" for the reason.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index ad9c1f5..7eac9ad 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -697,7 +697,7 @@ fs_visitor::no16(const char *format, ...)
>     } else {
>        simd16_unsupported = true;
>  
> -      if (INTEL_DEBUG & DEBUG_PERF) {
> +      if (brw->perf_debug) {
>           if (no16_msg)
>              ralloc_vasprintf_append(&no16_msg, format, va);
>           else
>