[Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

[Courtney Goeltzenleuchter]

Hi Ian,

I didn't think this even got out. I was getting a weird error from
git-send-mail when it tried to send to the gmail server and I got
distracted with other things.

Here's log:
Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
Password for 'smtp://courtney@lunarg.com@smtp.gmail.com:587':
OK. Log says:
Server: smtp.gmail.com
MAIL FROM:<courtney at LunarG.com>
RCPT TO:<mesa-dev at lists.freedesktop.org>
From: Courtney Goeltzenleuchter <courtney at LunarG.com>
To: mesa-dev at lists.freedesktop.org
Subject: [PATCH] mesa: add bounds checking to eliminate buffer overrun
Date: Mon,  7 Apr 2014 13:19:17 -0600
Message-Id: <1396898358-14649-1-git-send-email-courtney at LunarG.com>
X-Mailer: git-send-email 1.8.3.2
In-Reply-To: <CAE=6oPATsHZb3ZBH2HVD978tr=
FP_a3ng2RKCLqh2q-sUuzxuQ at mail.gmail.com>
References: <CAE=6oPATsHZb3ZBH2HVD978tr=
FP_a3ng2RKCLqh2q-sUuzxuQ at mail.gmail.com>

Result: 250 2.0.0 OK 1396898380 on9sm125685igb.11 - gsmtp

In git 1.7.0, the default has changed to --no-chain-reply-to
Set sendemail.chainreplyto configuration variable to true if
you want to keep --chain-reply-to as your default.
(mbox) Adding cc: Courtney Goeltzenleuchter <courtney at LunarG.com> from line
'From: Courtney Goeltzenleuchter <courtney at LunarG.com>'
(body) Adding cc: "9.2 10.0 10.1" <mesa-stable at lists.freedesktop.org from
line 'Cc: "9.2 10.0 10.1" <mesa-stable at lists.freedesktop.org'
error: unable to extract a valid address from: "9.2 10.0 10.1" <
mesa-stable at lists.freedesktop.org
What to do with this address? ([q]uit|[d]rop|[e]dit):

Looks like git-send-email is interpreting the commit message and trying to
add as a cc the last line: Cc: "9.2 10.0 10.1" <
mesa-stable at lists.freedesktop.org
<mailto:mesa-stable at lists.freedesktop.org>>

I'll give it another try.


On Mon, Apr 7, 2014 at 2:06 PM, Ian Romanick <idr at freedesktop.org> wrote:

> On 04/07/2014 12:19 PM, Courtney Goeltzenleuchter wrote:
> > Updated patch to include reference to bug that it resolves.
>
> Where?
>
> The proper way to do this is to send the path with git-send-mail, and
> include extra verbage in the commit message like:
>
> v3: Updated patch to include reference to bug that it resolves.
>
> Unless, of course, that update is just to add a Bugzilla: line to the
> commit message.  I don't know if that's the change because... :)
>
> > Since this fixes a buffer overrun in the driver (found running
> GLBenchmark's Manhattan test) I think it would be a good candidate for the
> stable branch.
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>


-- 
Courtney Goeltzenleuchter
LunarG
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140407/a47d1f91/attachment.html>