[Mesa-dev] [PATCH] svga: move LIST_INITHEAD(dirty_buffers) earlier in svga_context_create()

[Thomas Hellstrom]

Reviewed-by: Thomas Hellstrom <thellstrom at vmware.com>

On 04/09/2014 07:40 PM, Brian Paul wrote:
> Fixes a crash in svga_context_flush_buffers() if we use the 'draw' module
> for AA lines (when the device doesn't support that feature).  We need to
> initialize this list before we setup the swtnl pieces.
>
> Found/fixed by Charmaine Lee.
>
> Cc: "10.0" <mesa-stable at lists.freedesktop.org>
> ---
>  src/gallium/drivers/svga/svga_context.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/svga/svga_context.c b/src/gallium/drivers/svga/svga_context.c
> index 0ba09ce..8389384 100644
> --- a/src/gallium/drivers/svga/svga_context.c
> +++ b/src/gallium/drivers/svga/svga_context.c
> @@ -123,6 +123,8 @@ struct pipe_context *svga_context_create( struct pipe_screen *screen,
>     if (svga == NULL)
>        goto no_svga;
>  
> +   LIST_INITHEAD(&svga->dirty_buffers);
> +
>     svga->pipe.screen = screen;
>     svga->pipe.priv = priv;
>     svga->pipe.destroy = svga_destroy;
> @@ -185,8 +187,6 @@ struct pipe_context *svga_context_create( struct pipe_screen *screen,
>  
>     svga->dirty = ~0;
>  
> -   LIST_INITHEAD(&svga->dirty_buffers);
> -
>     check_for_workarounds(svga);
>  
>     return &svga->pipe;