[Mesa-dev] [PATCH v2 4/5] st/xa: handle solid-fill src/mask

[Rob Clark]

On Wed, Apr 9, 2014 at 1:59 PM, Thomas Hellstrom <thellstrom at vmware.com> wrote:
> Hi, Rob!
>
> On 04/08/2014 10:48 PM, Rob Clark wrote:
>> From: Rob Clark <robclark at freedesktop.org>
>>
>> Add support to property handle solid-fill src and/or mask.  Without this
>> we fallback to sw a lot for common things like text rendering.
>>
>> Signed-off-by: Rob Clark <robclark at freedesktop.org>
>> ---
>>  src/gallium/state_trackers/xa/xa_composite.c | 115 +++++------
>>  src/gallium/state_trackers/xa/xa_priv.h      |  13 +-
>>  src/gallium/state_trackers/xa/xa_renderer.c  | 298 ++++++++++++++++-----------
>>  src/gallium/state_trackers/xa/xa_tgsi.c      |  36 +++-
>>  4 files changed, 263 insertions(+), 199 deletions(-)
>>
>> diff --git a/src/gallium/state_trackers/xa/xa_composite.c b/src/gallium/state_trackers/xa/xa_composite.c
>> index 7ae35a1..b70fd47 100644
>> --- a/src/gallium/state_trackers/xa/xa_composite.c
>> +++ b/src/gallium/state_trackers/xa/xa_composite.c
>> @@ -111,12 +111,6 @@ blend_for_op(struct xa_composite_blend *blend,
>>      boolean supported = FALSE;
>>
>>      /*
>> -     * Temporarily disable component alpha since it appears buggy.
>> -     */
>> -    if (mask_pic && mask_pic->component_alpha)
>> -     return FALSE;
>> -
>> -    /*
>>

oh, I guess that hunk should have been a different patch anyways (even
if it worked)

> I'll attach the rendercheck logs of two early regression. The first one
> (log1.txt) happens because we enable component_alpha here.
> The second one is with component alpha disabled again.

hmm.. that almost looks like a vertex shader issue (if I'm
understanding what rendercheck is saying properly).  Like the mask
coords are wrong?

BR,
-R

> /Thomas
>
>