[Mesa-dev] [PATCH 2/3] i965: Add is_accumulator() function.

Matt Turner mattst88 at gmail.com
Wed Apr 9 15:18:58 PDT 2014


On Wed, Apr 9, 2014 at 3:13 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 04/09/2014 01:47 PM, Matt Turner wrote:
>> From: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
>>
>> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
>> ---
>> As a follow-on patch series, we should move common fields from fs_reg
>> and vec4's reg into a backend_reg and consolidate these functions.
>
> Yeah, there's been some talk about creating one of those.
>
> But even at present, src_reg and dst_reg both inherit from reg.
> is_accumulator() should be defined there, not in both subclasses.

Yeah. That's what made me notice. I don't care to do a partial fix now.


More information about the mesa-dev mailing list