[Mesa-dev] [PATCH] softpipe: fix shadow sampling and remove nonsensical approximation of linear interpolation behavior for shadow samplers.

Roland Scheidegger sroland at vmware.com
Mon Apr 14 07:19:38 PDT 2014


Am 11.04.2014 09:14, schrieb Janzing, Heinrich:
> Shadow sampling appeared to be fundamentally broken; fix in
> attachment.
> 

This looks ok to me (I put in the comment about this not making sense in
the first place...).
It should be noted though and I'd have preferred if a comment would
still say that somewhere that even with this the behavior isn't quite
right neither (though arguably much better) and the reason I didn't
actually fix it at that time since it was a bit more complex, what will
happen is that we'll do bilinear filter first, then replace with 0/1
depending on the filtered result. GL actually allows this but ideally
you'd really exchange the values with 0/1 _before_ doing the bilinear
filter.

Roland


More information about the mesa-dev mailing list