[Mesa-dev] [PATCH 0/7] translate_sse fixes

[Jose Fonseca]

This is not a review but just a side remark:  I strongly believe that in the medium/long term translate_sse and rtasm modules should be abandoned, and replaced with a new translate_llvm.c module.  All the functionality for doing so is already in draw/gallivm modules, it's really just a re-factoring exercise. (It would actually be a great project for somebody wanting to play with Mesa/LLVM.)

Jose

----- Original Message -----
> Hello, I noticed and incorrect uint->float conversion of vertex shader
> input in an application I'm working on, so I set out to fix it.
> In the meantime the application changed to avoid that conversion
> because it seems broken in too many drivers.
> 
> So anyway, this series contains two actual bug fixes in patches 4 and
> 5. The others are non-functional changes, mostly for readability.
> 
> Andreas Hartmetz (7):
>   translate_sse: Explain what struct translate_buffer_variant is for.
>   translate_sse: Rename translate_buffer_variant to translate_group.
>   translate_sse: Make those comments less abstract.
>   translate_sse: Use the correct buffer index in this fast path.
>   translate_sse: Preserve low bit during unsigned -> float conversion.
>   translate_sse: Be more specific in comment about loss of precision.
>   translate_sse: Remove a stray break;
> 
>  src/gallium/auxiliary/translate/translate_sse.c | 140
>  ++++++++++++++----------
>  1 file changed, 84 insertions(+), 56 deletions(-)
> 
> --
> 1.9.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=gAClnwqlXE5tkc8ucbi4zwe5D6MmPG2ixsGJ7X5xjLA%3D%0A&s=9730d3e58a7d70389a841f8ba06dfc80471c275feb692da97b1b43e7968a5f2b
>