[Mesa-dev] [PATCH v2 0/5] XA composite and perf improvements and fixes

[Rob Clark]

On Wed, Apr 16, 2014 at 9:09 AM, Thomas Hellstrom <thellstrom at vmware.com> wrote:
> Hi, Rob,
>
> Do you think we can push patches 1 trough 3 with a CC to stable for
> patch 3?

yes please.. you can push, or I can.. I was just waiting to hear back
from you on the later patches.  I meant to propose merging the first 3
but got distracted with other things ;-)

BR,
-R

> (It for some reason fixes a rendering error with motif on vmwgfx).
>
> I'm still looking into patches 4 and 5 to investigate why I get
> rendering errors.
>
> /Thomas
>
>
> On 04/08/2014 10:48 PM, Rob Clark wrote:
>> From: Rob Clark <robclark at freedesktop.org>
>>
>> While still more of a stop-gap solution (until glamor) for freedreno,
>> with these few relatively simple changes I get a pretty big performance
>> boost (~40%) for xf86-video-freedreno.
>>
>> Since the first iteration of these patches, I have:
>>  * re-worked the 'solid-fill src/mask' patch to always use SAMP[0..n]
>>    rather than hard-coding SAMP[0] to src and SAMP[1] to mask (to avoid
>>    having a NULL sampler[0]
>>  * Thomas's version of the 'cache render target surface' patch
>>  * Added a patch to fix some problems with xRGB -> a8 operations
>>
>> With this, especially after the 'xrgb->a' patch, rendercheck is at least
>> not exploding.  Some tests are still failing, but that appears to be
>> freedreno issues which I am still looking into.  (Mostly problems with
>> some oddball formats.)
>>
>> Rob Clark (4):
>>   st/xa: remove unneeded args
>>   st/xa: scissor to help tilers
>>   st/xa: handle solid-fill src/mask
>>   st/xa: handle xrgb->a better
>>
>> Thomas Hellstrom (1):
>>   st/xa: Cache render target surface
>>
>>  src/gallium/state_trackers/xa/xa_composite.c | 129 ++++++-----
>>  src/gallium/state_trackers/xa/xa_context.c   |  26 ++-
>>  src/gallium/state_trackers/xa/xa_priv.h      |  55 ++++-
>>  src/gallium/state_trackers/xa/xa_renderer.c  | 319 ++++++++++++++++-----------
>>  src/gallium/state_trackers/xa/xa_tgsi.c      |  73 ++++--
>>  src/gallium/state_trackers/xa/xa_yuv.c       |   2 +-
>>  6 files changed, 380 insertions(+), 224 deletions(-)
>>