[Mesa-dev] [Mesa-stable] [PATCH 3/7] linker: Fold set_uniform_binding into call site

[Kenneth Graunke]

On 04/16/2014 04:59 PM, Carl Worth wrote:
> Ian Romanick <idr at freedesktop.org> writes:
>> variable.  That's never passed to set_uniform_binding, and it's easier
>> to just remove the function (especially for later patches in the series)
>> than to add another parameter.
> 
> Hi Ian,
> 
> I should have looked closer at this commit when I was reviewing it for
> the stable series.
> 
> The commit message and structure of the patch led me to believe that a
> function was being inlined without a behavioral change.
> 
> However, the new assert is causing regressions for the following piglit
> tests:
> 
>  all/spec/ARB_shader_atomic_counters
> 	active-counters
>         compiler/
> 		expression-allowed.frag
> 		default-partition
> 		fragment-discard
> 		function-argument 
> 
> Such as:
> 
> $ ./bin/arb_shader_atomic_counters-active-counters -fbo -auto 
> arb_shader_atomic_counters-active-counters: ../../src/glsl/link_uniform_initializers.cpp:257: void link_set_uniform_initializers(gl_shader_program*): Assertion `!"Explicit binding not on a sampler or UBO."' failed.
> Aborted
> 
> Other than this set of regressions, I like the state of the 10.1 branch
> I have. What do you recommend?
> 
> -Carl

For what it's worth, Chris Forbes sent out a patch which purports to fix
this:

http://lists.freedesktop.org/archives/mesa-dev/2014-April/057718.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140417/653e0cc5/attachment.sig>