[Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CLOCK_FREQUENCY

[Bruno Jimenez]

On Fri, 2014-04-18 at 12:08 +0200, Francisco Jerez wrote:
> Bruno Jiménez <brunojimen at gmail.com> writes:
> 
> > From: Tom Stellard <thomas.stellard at amd.com>
> >
> > ---
> >  src/gallium/include/pipe/p_defines.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> > index a3a1ae1..93f9642 100644
> > --- a/src/gallium/include/pipe/p_defines.h
> > +++ b/src/gallium/include/pipe/p_defines.h
> > @@ -641,7 +641,8 @@ enum pipe_compute_cap
> >     PIPE_COMPUTE_CAP_MAX_LOCAL_SIZE,
> >     PIPE_COMPUTE_CAP_MAX_PRIVATE_SIZE,
> >     PIPE_COMPUTE_CAP_MAX_INPUT_SIZE,
> > -   PIPE_COMPUTE_CAP_MAX_MEM_ALLOC_SIZE
> > +   PIPE_COMPUTE_CAP_MAX_MEM_ALLOC_SIZE,
> > +   PIPE_COMPUTE_CAP_MAX_CLOCK_FREQUENCY,
> 
> You should also update the docs (src/gallium/docs/source/screen.rst)
> with a short description of the new compute cap -- specifically, in
> which unit is the clock frequency expressed.  Wouldn't it make more
> sense to express it in MHz as it was in the original patch series so it
> matches what OpenCL expects?

Sure, I will add it. But the original series returned the max clock
frequency in kHz, that's why I added the conversion to the third patch.
I will change the conversion to the second patch so that
r600_get_compute_param expresses it in MHz.

- Bruno

> 
> >  };
> >  
> >  /**
> > -- 
> > 1.9.2
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev