[Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CLOCK_FREQUENCY

[Francisco Jerez]

Bruno Jiménez <brunojimen at gmail.com> writes:

> From: Tom Stellard <thomas.stellard at amd.com>
>
> v2: Updated the docs
> ---
>  src/gallium/docs/source/screen.rst   | 2 ++
>  src/gallium/include/pipe/p_defines.h | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst
> index 5c255d0..3f38b28 100644
> --- a/src/gallium/docs/source/screen.rst
> +++ b/src/gallium/docs/source/screen.rst
> @@ -310,6 +310,8 @@ pipe_screen::get_compute_param.
>    resource.  Value type: ``uint64_t``.
>  * ``PIPE_COMPUTE_CAP_MAX_MEM_ALLOC_SIZE``: Maximum size of a memory object
>    allocation in bytes.  Value type: ``uint64_t``.
> +* ``PIPE_COMPUTE_CAP_MAX_CLOCK_FREQUENCY``: Maximum frequency of the GPU
> +  clock in MHz. Value type: ``uint32_t``
>  
>  .. _pipe_bind:
>  
> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> index a3a1ae1..93f9642 100644
> --- a/src/gallium/include/pipe/p_defines.h
> +++ b/src/gallium/include/pipe/p_defines.h
> @@ -641,7 +641,8 @@ enum pipe_compute_cap
>     PIPE_COMPUTE_CAP_MAX_LOCAL_SIZE,
>     PIPE_COMPUTE_CAP_MAX_PRIVATE_SIZE,
>     PIPE_COMPUTE_CAP_MAX_INPUT_SIZE,
> -   PIPE_COMPUTE_CAP_MAX_MEM_ALLOC_SIZE
> +   PIPE_COMPUTE_CAP_MAX_MEM_ALLOC_SIZE,
> +   PIPE_COMPUTE_CAP_MAX_CLOCK_FREQUENCY,

The trailing comma at the end of an enumeration list is not allowed by
the standard until C99/C++11 AFAIK.  This probably works with GCC or
clang as an extension but I'm not sure if it will be a problem for VC++.
Can you leave that out?  With that fixed this patch is:

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

>  };
>  
>  /**
> -- 
> 1.9.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140418/68a21c2e/attachment.sig>