[Mesa-dev] Mesa (master): mesa/st: Fix pipe_framebuffer_state:: height for PIPE_TEXTURE_1D_ARRAY.

[Michel Dänzer]

On 24.04.2014 03:12, Jose Fonseca wrote:
> Module: Mesa
> Branch: master
> Commit: fd92346c53ed32709c7b56ce58fb9c9bf43ce9a8
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd92346c53ed32709c7b56ce58fb9c9bf43ce9a8
> 
> Author: José Fonseca <jfonseca at vmware.com>
> Date:   Thu Apr  3 15:56:46 2014 +0100
> 
> mesa/st: Fix pipe_framebuffer_state::height for PIPE_TEXTURE_1D_ARRAY.
> 
> This prevents buffer overflow w/ llvmpipe when running piglit
> 
>   bin/gl-3.2-layered-rendering-clear-color-all-types 1d_array single_level -fbo -auto
> 
> v2: Compute the framebuffer size as the minimum size, as pointed out by
> Brian;  compacted code;  ran piglit quick test list (with no
> regressions.)

This commit broke the piglit test drawbuffer-modes for me with radeonsi:

../../../src/mesa/state_tracker/st_atom_framebuffer.c:153:update_framebuffer_state:
Assertion `framebuffer->width != (2147483647 * 2U + 1U)' failed.
Apr 24 16:38:02 kaveri kernel: [26036.258250] traps:
drawbuffer-mode[6292] trap int3 ip:7f50e6f52526 sp:7ffffcc82640 error:0
zsh: trace trap  DISPLAY=:1
/home/daenzer/src/piglit-git/piglit/bin/drawbuffer-modes -auto

The test was previously passing.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer