[Mesa-dev] [PATCH] st/xlib: Do minimal version checking in glXCreateContextAttribsARB.
jfonseca at vmware.com
jfonseca at vmware.com
Thu Apr 24 07:51:02 PDT 2014
From: José Fonseca <jfonseca at vmware.com>
The current version checking is wrongly refusing to create 3.3 contexts;
unsupported version are checked elsewhere; and the DRI path doesn't do
this sort of checking neither.
This enables piglit glsl 3.30 tests to run without skipping.
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/src/gallium/state_trackers/glx/xlib/glx_api.c b/src/gallium/state_trackers/glx/xlib/glx_api.c
index 05880dd..d97cbd7 100644
--- a/src/gallium/state_trackers/glx/xlib/glx_api.c
+++ b/src/gallium/state_trackers/glx/xlib/glx_api.c
@@ -2724,26 +2724,8 @@ glXCreateContextAttribsARB(Display *dpy, GLXFBConfig config,
}
/* check version (generate BadMatch if bad) */
- switch (majorVersion) {
- case 1:
- if (minorVersion < 0 || minorVersion > 5)
- return NULL;
- break;
- case 2:
- if (minorVersion < 0 || minorVersion > 1)
- return NULL;
- break;
- case 3:
- if (minorVersion < 0 || minorVersion > 2)
- return NULL;
- break;
- case 4:
- if (minorVersion < 0 || minorVersion > 0)
- return NULL;
- break;
- default:
+ if (majorVersion < 0 || minorVersion < 0)
return NULL;
- }
if ((contextFlags & GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB) &&
majorVersion < 3)
--
1.8.3.2
More information about the mesa-dev
mailing list