[Mesa-dev] [PATCH 13/19] i965/fs: Only consider real sources when comparing instructions.

Matt Turner mattst88 at gmail.com
Thu Apr 24 08:31:36 PDT 2014


On Wed, Apr 23, 2014 at 11:56 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> At any rate, adding the assertion makes it obvious that this code is
> correct by design, and we didn't just forget to update it for
> arbitrary-length source lists...I don't think it's an unreasonable
> request...

If we want to document that all commutative operations are binary,
that's okay. I just don't see anything in this patch that increases
the need for the assertion. The patch is just changing the
non-commutative case to check 1-n arguments instead of 1-3. If I'd
seen this patch and it added the assertion I would have wondered why
it did two unrelated things.


More information about the mesa-dev mailing list